This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RESEND PATCH v9] Mutex: Add pthread mutex tunables


On 11/29/18 9:41 AM, Florian Weimer wrote:
> * Kemi Wang:
> 
>> +# 	     SXID_ERASE: (default) Don't read for AT_SECURE binaries and
>> +# 	     		 removed so that child processes can't read it.
> 
> I think this will not work as intended for libpthread tunables because
> if libpthread is not linked in, no code in nptl/nptl-init.c ever runs.
> 
> I think we need to move the tunable to elf/dl-tunables.list, parse it
> there, and communicate the result to libpthread, possibly via
> _rtld_global_ro.

This is a fairly arcane issue with tunables, are we certain this is a
problem? I'd rather not have new contributors need to handle this, but
that we fix it ourselves and then have Kemi follow established practice
(like putting it in elf/dl-tunables.list and passing the value to
libpthread, or just using sysdeps/nptl/dl-tunables.list).

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]