This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add --no-hard-links option to localedef (Bug 23923)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Mon, 26 Nov 2018 16:58:58 +0000
- Subject: Re: [PATCH] Add --no-hard-links option to localedef (Bug 23923)
- References: <751dddf5-84fa-190f-19ff-073c267822a9@redhat.com>
On Mon, 26 Nov 2018, Carlos O'Donell wrote:
> If the downstream distro wants to post-process the hardlinks then
> the time spent in localedef looking up sibling directories and
> processing hardlinks is wasted effort.
Do you have figures for the time involved?
> + other locales, and see if we can reuse it, to save disk space.
> + If the user specified --no-hard-link to localedef then hard_links is
> + false, other_paths remains NULL and we skip the optimization below.
> + The use of --no-hard-link is distribution specific since some distros
> + have post-processing hard-link steps and so doing this here is a waste
> + of time. */
This should refer to --no-hard-links, not --no-hard-link (twice).
This is not a review of other aspects of the patch (but I approve of
improving determinism of the locale build, and also have such a hard-link
post-processing step at Mentor).
--
Joseph S. Myers
joseph@codesourcery.com