This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 2/2] mtrace: record backtrace of memory allocation/deallocation


Hi Joseph,
Thanks for reviewing my patch.

On 21/11/18 05:44, Joseph Myers wrote:
> On Tue, 20 Nov 2018, Kyeong Yoo wrote:
> 
>> New test is added for mtrace with backtrace output.
>> It is simply to check when the feature is turned on, backtrace appeares
>> in the mtrace output.
> 
> I don't see anything here to add a configure test for the appropriate
> cross-compilation addr2line program and to pass the right option to
> mtrace - does the test succeed anyway in a cross-compilation environment
> even with mtrace using the native addr2line?
The test I'm adding is for backtrace output from mtrace().
The case of cross-compilation is not there. If you have any suggestion 
of how to test cross-compilation case, please let me know.
For cross-compilation, native addr2line may mostly print the address 
with no meaningful source line (mostly ??:0).

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]