This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251)
- From: Samuel Thibault <samuel dot thibault at gnu dot org>
- To: libc-alpha at sourceware dot org, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Date: Thu, 15 Nov 2018 02:36:48 +0100
- Subject: Re: Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251)
- References: <20181115012457.ssscem7zfceifykq@function> <20181115012939.il77yr2gxkxyswu6@function>
Samuel Thibault, le jeu. 15 nov. 2018 02:29:39 +0100, a ecrit:
> Samuel Thibault, le jeu. 15 nov. 2018 02:24:57 +0100, a ecrit:
> > In login/utmp_file.c you have replaced calling __fcntl_nocancel by
> > __fcntl64_nocancel, but shouldn't struct flock be replaced by struct
> > flock64 too?
>
> Ah, no, applications *have* to use F_SETLK64 to use struct flock64, is
> that it?
Mmm, no, as I read the Linux implementation, when calling fcntl(), one
has to use F_SETLK64 to be able to use struct flock64, but when calling
fcntl64(), struct flock64 is always used,a and thus login/utmp_file.c
should really be useing struct flock64?
Samuel