This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/8] Use STRFMON_LDBL_IS_DBL instead of __ldbl_is_dbl.


On Wed, 07 Nov 2018, Adhemerval Zanella wrote:
>On 29/10/2018 09:16, Gabriel F. T. Gomes wrote:
>> From: Zack Weinberg <zackw@panix.com>
>>
>> +extern ssize_t
>> +__vstrfmon_l_internal (char *s, size_t maxsize, locale_t loc,
>> +		       const char *format, va_list ap,
>> +		       unsigned int flags)
>> +  attribute_hidden;
>> +
>> +/* Flags for __vstrfmon_l_internal.  */
>> +#define STRFMON_LDBL_IS_DBL 0x0001  
>
>Please extend the flag comment to describe what it does.

With the proposed text (below) and DCO's signed-off-by statements removed
from the commit message, is it OK for master?

+/* Flags for __vstrfmon_l_internal.
+
+   STRFMON_LDBL_IS_DBL is a one-bit mask for the flags parameter that
+   indicates whether long double values are to be handled as having the
+   same format as double, in which case the flag should be set to one,
+   or as another format, otherwise.  */
+#define STRFMON_LDBL_IS_DBL 0x0001


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]