This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Merge mktime, timegm from upstream Gnulib

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 9 Nov 2018 19:51:31 -0800
Subject: Re: [PATCH 1/2] Merge mktime, timegm from upstream Gnulib
References: <20180909160625.15214-1-eggert@cs.ucla.edu> <87sh13f2hz.fsf@oldenburg.str.redhat.com> <87o9brf200.fsf@oldenburg.str.redhat.com>

Florian Weimer wrote:

It happens for the /usr/share/zoneinfo/America/Sao_Paulo file from
tzdata-2018e-1.fc27.  So the test case is not properly isolated, either.

The test case should work regardless of what's in that file, and should workeven if that file does not exist or if there's an I/O error reading it. As Ivaguely recall, the original bug report was against TZ=America/Sao_Paulo andthat's why the test case uses that particular setting.

It'd probably be good to add "<-03>3<-02>,M11.1.0/0,M2.3.0/0" to the tz_stringsarray in that test case, to do a southern-hemisphere-style test even if theSao_Paulo file contains garbage or does not exist. I don't recall the originalproblem well enough to know whether such an addition to tz_strings would sussout the Sao_Paulo bug.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]