This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tcache double free check


* DJ Delorie:

> Florian Weimer <fweimer@redhat.com> writes:
>>> +      /* If we get here, it was a coincidence.  We've wasted a few
>>> +	 cycles, but don't abort.  */
>>> +    }
>>
>> One more thing:
>>
>> I think you should put an Systemtap probe here, perhaps counting the
>> length of the chain and logging the index, so that we can debug
>> performance issues here.
>
> In tcache_get/tcache_put, or in this unlikely block?

In this unlikely block.  Tcache instrumentation is a separate matter.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]