This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: V2 [PATCH] Check multiple NT_GNU_PROPERTY_TYPE_0 notes [BZ #23509]


* H. J. Lu:

> Here is the updated patch with
>
> Linkers group input note sections with the same name into one output
> note section with the same name.  One output note section is placed in
> one PT_NOTE segment.  Since new linkers merge input .note.gnu.property
> sections into one output .note.gnu.property section, there is only
> one NT_GNU_PROPERTY_TYPE_0 note in one PT_NOTE segment with new linkers.
> Since older linkers treat input .note.gnu.property section as a generic
> note section and just concatenate all input .note.gnu.property sections
> into one output .note.gnu.property section without merging them, we may
> see multiple NT_GNU_PROPERTY_TYPE_0 notes in one PT_NOTE segment with
> older linkers.

Thanks.  This hypothesis regarding older linkers seems reasonable, and
the explanation is very clear now.  The code looks okay to me.

Would you please backport this to the 2.28 release branch as well?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]