This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2 5/8] Add __v*printf_internal with flags arguments.
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 8 Nov 2018 15:24:36 -0200
- Subject: Re: [PATCH v2 5/8] Add __v*printf_internal with flags arguments.
- References: <email@example.com> <firstname.lastname@example.org> <email@example.com>
On 07/11/2018 16:53, Adhemerval Zanella wrote:
> On 29/10/2018 09:16, Gabriel F. T. Gomes wrote:
>> From: Zack Weinberg <firstname.lastname@example.org>
>> There are a lot more printf variants than there are scanf variants,
>> and the code for setting up and tearing down their custom FILE
>> variants around the call to __vf(w)printf is more complicated and
>> variable. Therefore, I have added _internal versions of all the
>> v*printf variants, rather than introducing helper routines so that
>> they can all directly call __vf(w)printf_internal, as was done with
>> As with the scanf changes, in this patch the _internal functions still
>> look at the environmental mode bits and all callers pass 0 for the
>> flags parameter.
>> Several of the affected public functions had _IO_ name aliases that
>> were not exported (but, in one case, appeared in libio.h anyway);
>> I was originally planning to leave them as aliases to avoid having
>> to touch internal callers, but it turns out ldbl_*_alias only work
>> for exported symbols, so they've all been removed instead. It also
>> turns out there were hardly any internal callers. _IO_vsprintf and
>> _IO_vfprintf *are* exported, so those two stick around.
Please add a note that it fixes BZ#11319 by unifing both fortified and
non-fortified vdprintf initialization.