This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Indentation, tabs, and spaces (was re: [PATCH] support: Implement TEST_COMPARE_STRING)


On Thu, 8 Nov 2018, David Newall wrote:

> Reformatting makes it difficult to see what was changed using diff and so, in

Naturally it should be done in a separate commit from any substative 
changes (and such a change could be verified with build-many-glibcs.py not 
to change installed stripped shared libraries for any configuration, 
except where assertion line numbers are involved).

> my opinion, should never be done; and particularly not for petty reasons like
> indent.

*Not* reformatting makes parts of the code hard to read, and hard to edit 
(as you need to keep fixing up indentation manually every line when 
editing code not following the normal style), and in practice the 
hard-to-read issue gets worse over time as the formatting does not stay 
consistent with a style people aren't familiar with maintaining code in.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]