This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] support: Implement TEST_COMPARE_STRING


* Gabriel F. T. Gomes:

>>+/* Compare the strings LEFT and RIGHT and report a test failure if
>>+   they are different.  Also report failure if one of the arguments is
>>+   a null pointer and the other is not.  The strings should be
>>+   reasonably short because on mismatch, both are printed.  */
>>+#define TEST_COMPARE_STRING(left, right)                         \
>>+  (support_test_compare_string (left, right, __FILE__, __LINE__, \
>>+                                #left, #right))
>   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Spaces instead of tabs.

I wasn't aware that we have a policy to use tabs.  Most of my changes
involving new files do not use tabs. 8-/

I personally find tabs problematic because they make it pretty much
impossible to review diffs for correct indentation, which is why I avoid
them in new files.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]