This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
Cc: libc-alpha at sourceware dot org, Gnulib bugs <bug-gnulib at gnu dot org>
Date: Tue, 6 Nov 2018 16:28:36 -0800
Subject: Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
References: <20181030111850.5322-1-albert.aribaud@3adev.fr> <9947f682-fc46-f2d6-4b07-536c03b9e657@cs.ucla.edu> <e9704996-c39a-d4cb-2a62-b0342924cdc5@cs.ucla.edu> <20181106064306.45eda0c2@athena> <20181106214147.6391743b@athena>

On 11/6/18 12:41 PM, Albert ARIBAUD wrote:

Issue is that __mktime_internal exited through

     else if (--remaining_probes == 0)
       return -1;

with errno never set.

Any idea why?

Either localtime_r is failing without setting errno so the bug is inlocaltime_r, or localtime_r never fails and so never sets errno so thebug is in mktime. Can you check which of these is happening?

Follow-Ups:
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD

References:
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
  - From: Paul Eggert
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
  - From: Paul Eggert
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]