This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
- From: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: libc-alpha at sourceware dot org, Gnulib bugs <bug-gnulib at gnu dot org>
- Date: Tue, 6 Nov 2018 21:41:47 +0100
- Subject: Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
- References: <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <20181106064306.45eda0c2@athena>
On Tue, 6 Nov 2018 06:43:06 +0100, Albert ARIBAUD
<email@example.com> wrote :
> Hi Paul,
> On Sun, 4 Nov 2018 23:54:59 -0800, Paul Eggert <firstname.lastname@example.org>
> wrote :
> > Paul Eggert wrote:
> > > 3. Please construct a third patch containing your mktime test case for glibc,
> > > and we then apply that patch to glibc.
> > I looked at that test case and found some issues with it, e.g., it assumed a
> > particular time_t width in some cases and assumed a particular error number in
> > others. Attached is a revised test case that should fix the issues. For
> > convenience I'm also attaching the same glibc code patch again.
> Apparently, with both your patches applied there are still paths which
> yield "mktime failed without setting errno" when make check is run for
> i686-linux-gnu. I'll go through the call path and see where it fails.
Issue is that __mktime_internal exited through
else if (--remaining_probes == 0)
with errno never set.
Any idea why?