This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] stdlib/test-bz22786: Avoid spurious test failures using alias mappings


* Rafal Luzynski:

> 26.10.2018 20:11 Florian Weimer <fweimer@redhat.com> wrote:
>> 
>> On systems without enough random-access memory, stdlib/test-bz22786
>> will go deeply into swap and time out, even with a substantial
>> TIMEOUTFACTOR.  This commit adds a facility to construct repeating
>
> The macro is actually named TIMEOUT rather than TIMEOUTFACTOR.
> Maybe you meant "TIMEOUT factor" or "TIMEOUT macro" or "TIMEOUT value"?

TIMEOUTFACTOR is an environment variable which can be used to scale
TIMEOUT, for particularly slow systems.

>> strings with alias mappings, so that the requirement for physical
>> memory, and uses it in stdlib/test-bz22786.
>> 
>> With 1 GiB RAM, execution time of the test goes from
>> 
>> 1.72user 5.68system 2:05.25elapsed 5%CPU (0avgtext+0avgdata
>> 920932maxresident)k
>> 8453744inputs+0outputs (131431major+1145697minor)pagefaults 0swaps
>
> Can you please wrap the log comment at 76 column or below?

It's the standard output of the “time” command (not the shell built-in).

> Did you mean this part to go to the commit comment?

I just wanted to provide some justification for the complexity.  I can
drop it if it's unnecessary.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]