This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
Bonjour Paul,
Le Fri, 26 Oct 2018 17:10:26 -0700, Paul Eggert <eggert@cs.ucla.edu> a
écrit :
> On 10/26/18 4:26 PM, Albert ARIBAUD wrote:
> > Ok, so this requirement extends to all functions called by mktime(),
> > directly or indirectly (and ditto for gmtime).
>
> Hmm, well, I'm starting to see why you'd rather have mktime save and
> restore errno when there's not an error. That would also be OK, and that
> might lighten the load on the functions mktime calls.
Indeed. So, unless someone else disagrees, I will go with the "save
and restore errno" option, with of course adequate comments in the
code to make it clear why it does it and how.
Cordialement,
Albert ARIBAUD
3ADEV