This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: glibc bug 23789 (was: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t)

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
Cc: libc-alpha at sourceware dot org
Date: Thu, 25 Oct 2018 13:22:12 -0700
Subject: Re: glibc bug 23789 (was: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t)
References: <20181017093126.23422-1-albert.aribaud@3adev.fr> <9ce5d618-12cd-3dca-3e7f-1812cdd3a1ae@cs.ucla.edu> <20181024132318.52ba1647@athena> <20181024175930.7f27a568@athena>

On 10/24/18 8:59 AM, Albert ARIBAUD wrote:


BTW: Paul, your program returns 2 when errno is not EOVERFLOW, but 2 is
not supported as an EXIT_* value, only 0 (EXIT_SUCCESS), 1
(EXIT_FAILURE) and 77 (EXIT_UNSUPPORTED). I assume that was an ad hoc
choice to distinguish the "errno is not EOVERFLOW" failure from a
hypothetical "mktime did not return -1" failure.

Yes, that's right. The test was originally written without the testframework in mind.

References:
- [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t
  - From: Albert ARIBAUD (3ADEV)
- Re: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t
  - From: Paul Eggert
- Re: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t
  - From: Albert ARIBAUD
- glibc bug 23789 (was: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t)
  - From: Albert ARIBAUD

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]