This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [v13 2/2] Y2038: make __tz_convert compatible with 64-bit-time
On Wed, 24 Oct 2018, Albert ARIBAUD wrote:
> On Wed, 24 Oct 2018 18:33:15 +0200, Albert ARIBAUD
> <albert.aribaud@3adev.fr> wrote :
>
> > I'm fine with splitting the patch, keeping the internal changes here and
> > moving the public interface changes further down the series.
>
> In fact, I could even break the internal changes patch further, into
> one patch per internal function being changed. That would give:
>
> - one patch to switch __offtime to 64-bit-time arguments and adjust
> calls to it from __tzfile_compute and __tz_convert;
>
> - one patch to switch __tz_compute to 64-bit-time arguments and adjust
> calls to it from __tzfile_compute and __tz_convert;
>
> - one patch to switch __tzfile_compute to 64-bit-time arguments and
> adjust the call to it from __tz_convert;
>
> - one patch to switch __tz_convert to 64-bit-time argument and adjust
> the calls to it from gmtime, gmtime_r, localtime, and localtime_r.
>
> Which is the preferred way? Only one, big-ish patch, or a set of
> atomic ones?
I don't think splitting the internal changes by function is particularly
beneficial to the review, so in this case I'd say one patch with the
interface changes to all those functions.
--
Joseph S. Myers
joseph@codesourcery.com