This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v12 1/3] Y2038: provide size of default time_t for target architecture


* Albert ARIBAUD:

> Hi Florian,
>
> Le Tue, 23 Oct 2018 11:14:24 +0200, Florian Weimer <fweimer@redhat.com>
> a écrit :
>
>> If you still have doubts about the commit message or the ChangeLog
>> entry, I'm happy to review it for you prior to making the change
>> official.
>
> Thanks. I have prepared my master branch locally, and pushed it on the
> glibc repo as the branch aaribaud/master for you to have a look at.
> Right now, I am running a fast make check as per the checklist.

I think the ChangeLog should list the names of macros being changed, so
something like thiss:

	* sysdeps/unix/sysv/linux/mips/bits/msq-pad.h
        (__MSQ_PAD_AFTER_TIME, __SHM_PAD_BETWEEN_TIME_AND_SEGSZ): Use
        __TIMESIZE instead of __WORDSIZE.

Otherwise, looks good.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]