This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Enable VDSO on statically linked programs.

From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
To: Rafael Avila de Espindola <rafael at espindo dot la>, "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: nd at arm dot com, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
Date: Mon, 24 Sep 2018 10:28:58 +0100
Subject: Re: [PATCH v2] Enable VDSO on statically linked programs.
References: <Rt9LNuZNJXNeI-mSgZ_YAja7MzVVLO7IYVyN2uyhHcnpBpJH9yzQATx-2GaiHZoMA6mScM6GvrheNFkdCQK4ZGmDbbXhVJ-RI1dp0AGlezA=@espindo.la> <CAMe9rOppStbmn2ti4HyH0HhExbCvrujviE7Xn_o_1ghwyYu5DA@mail.gmail.com> <XNcH30lFg98oSB9zboHnE6yyWrf17zM7Tvwn8I6dmLaVx6FNrcxBMdW7wGJRygN2T9StKHxBJG6D2_zvj9D-USL_avfn-B12BaxdVn3JqV8=@espindo.la>

On 24/09/18 02:24, Rafael Avila de Espindola wrote:

"H.J. Lu" <hjl.tools@gmail.com> writes:

On Fri, Sep 21, 2018 at 4:40 PM, Rafael Avila de Espindola
<rafael@espindo.la> wrote:

The new version has fixed the indentation of preprocessor directives and changed a few tests to also be linked statically. The tests don't show that the VDSO is being used, but show that the functions now using the VDSO still work.


2 comments:

1.  Why isn't i386 enabled?


It is probably better to do other architectures as a follow up, no? I do
volunteer to do at least i386.

2.  ChangeLog entries are missing.


Sorry, it is

2018-09-23  Rafael Ávila de Espíndola  <rafael@espindo.la>

         * nptl/Makefile: Add tst-cond11-static to tests-static and tests.
         * nptl/tst-cond11-static.c: New File.
         * sysdeps/unix/sysv/linux/sysdep-vdso.h: remove #ifdef SHARED.
         * sysdeps/unix/sysv/linux/x86/libc-vdso.h: remove #ifdef SHARED.
         * sysdeps/unix/sysv/linux/x86_64/init-first.c: remove #ifdef SHARED.
         * sysdeps/unix/sysv/linux/Makefile: Add tst-affinity-static to
         tests-static and tests
         * sysdeps/unix/sysv/linux/tst-affinity-static.c: New file.



this should include the bug number 19767

the title as well as the description should make it clear that
only x86 behaviour is changed, this is a generic issue in glibc
and ideally all targets should have the same behaviour eventually.

it is also useful to mention if you tested the patch on non-x86
targets since the header changes seem to affect them.

References:
- [PATCH v2] Enable VDSO on statically linked programs.
  - From: Rafael Avila de Espindola
- Re: [PATCH v2] Enable VDSO on statically linked programs.
  - From: H.J. Lu
- Re: [PATCH v2] Enable VDSO on statically linked programs.
  - From: Rafael Avila de Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]