This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Y2038: add function __clock_settime64
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Albert ARIBAUD (3ADEV)" <albert dot aribaud at 3adev dot fr>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 19 Sep 2018 13:15:13 +0000
- Subject: Re: [PATCH] Y2038: add function __clock_settime64
- References: <20180919073553.28153-1-albert.aribaud@3adev.fr>
On Wed, 19 Sep 2018, Albert ARIBAUD (3ADEV) wrote:
> + if (! IS_VALID_NANOSECONDS(tp->tv_nsec))
Missing space.
> + if (! fits_in_time_t(tp->tv_sec)) \
Likewise.
> + valid_timespec64_to_timespec(tp, &ts32); \
Likewise.
> + if (retval == 1 && errno==ENOSYS) \
Likewise, around the ==.
Please check and fix the whole patch series for such coding style issues.
--
Joseph S. Myers
joseph@codesourcery.com