This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S
- From: Florian Weimer <fweimer at redhat dot com>
- To: Terry Guo <terry dot xpguo at gmail dot com>, libc-alpha at sourceware dot org
- Cc: hongjiu dot lu at intel dot com
- Date: Wed, 12 Sep 2018 09:43:25 +0200
- Subject: Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S
- References: <CAATtE7D_q4qd4Y9uTP-JmfJZ_zGT01HYYtKZW0L3_Q+v3TCegA@mail.gmail.com>
On 09/07/2018 09:06 AM, Terry Guo wrote:
+ /* Clearing frame pointer is insufficient, use CFI. */
+ cfi_undefined (eip)
Isn't this a separate fix?
The ChangeLog or the commit message should mention ENDBR32 (“Use ENTRY
to insert ENDBR32 when building for CET” or something like that).
Thanks,
Florian