This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc64: Remove support for !HAVE_INLINED_SYSCALLS


Florian Weimer <fweimer@redhat.com> writes:

> On 08/20/2018 06:29 PM, Adhemerval Zanella wrote:
>> 
>> 
>> On 20/08/2018 11:40, Florian Weimer wrote:
>>> HAVE_INLINED_SYSCALLS is always defined on Linux.
>>>
>>> 2018-08-20  Florian Weimer  <fweimer@redhat.com>
>>>
>>> 	* sysdeps/powerpc/powerpc64/dl-machine.h (DL_STARTING_UP_DEF):
>>> 	Remove macro.
>>> 	(RTLD_START): Adjust.
>> 
>> This file is not Linux specific, so it can potentially be used on a port
>> which defines HAVE_INLINED_SYSCALLS.  Is the plan to get rid of
>> HAVE_INLINED_SYSCALLS altogether?
>
> Do you plan to start a Hurd port for powerpc? 8-)

I agree with Adhemerval here, even if there isn't a plan to port powerpc to
Hurd.  :-D
But I do agree to remove it if this is causing a problem for you (and an
explanation of the reason in the commit message ;-) ).

> The condition looks wrong to me—it probably should be 
> RTLD_PRIVATE_ERRNO, not HAVE_INLINED_SYSCALLS.

Do you also plan to modify _dl_starting_up usages in other places?
e.g. elf/init.c
They're using _dl_starting_up based on HAVE_INLINED_SYSCALLS too.

> And I plan to get rid of the private errno for ld.so eventually on Linux.

If Linux always defines HAVE_INLINED_SYSCALLS, DL_STARTING_UP_DEF will be
defined to nothing.  How is this patch helping your work on the private errno
removal?

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]