This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nscd: Deallocate existing user names in file parser


fweimer@redhat.com (Florian Weimer) writes:
> -	    server_user = xstrdup (arg1);
> +	    {
> +	      free ((char *) server_user);
> +	      server_user = xstrdup (arg1);
> +	    }

server_user is global and unitialized, so initialized to NULL.  free()
allows the passed pointer to be NULL.  So this is OK.

Note that free() nominally takes a void*, not a char*.  I think we
should use void* in this case.

>  	    {
> +	      free ((char *) stat_user);
>  	      stat_user = xstrdup (arg1);

Same here.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]