This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] soft-fp: Add the lack of implementation for 128 bit self-contained.
- From: Zong Li <zongbox at gmail dot com>
- To: joseph at codesourcery dot com
- Cc: Zong Li <zong at andestech dot com>, Palmer Dabbelt <palmer at dabbelt dot com>, darius at bluespec dot com, Andrew Waterman <andrew at sifive dot com>, dj at redhat dot com, libc-alpha at sourceware dot org, Richard Henderson <rth7680 at gmail dot com>
- Date: Thu, 26 Jul 2018 20:45:19 +0800
- Subject: Re: [PATCH v2] soft-fp: Add the lack of implementation for 128 bit self-contained.
- References: <1532581161-6380-1-git-send-email-zong@andestech.com> <alpine.DEB.2.20.1807261201010.6917@digraph.polyomino.org.uk>
Joseph Myers <joseph@codesourcery.com> 於 2018年7月26日 週四 下午8:03寫道:
>
> On Thu, 26 Jul 2018, Zong Li wrote:
>
> > + fa8_c = (fa8_c ? \
> > + R##_f[fa8_i] <= X##_f[fa8_i] : \
> > + R##_f[fa8_i] < X##_f[fa8_i]); \
>
> GNU formatting breaks lines before operators, not after, so ? and : at
> start not end of lines.
>
> > + fs8_c = (fs8_c ? \
> > + R##_f[fs8_i] >= X##_f[fs8_i] : \
> > + R##_f[fs8_i] > X##_f[fs8_i]); \
>
> Likewise.
>
> > + (R) += _FP_W_TYPE_SIZE*2; \
>
> GNU formatting uses spaces around binary operators such as *.
>
> > +#define _FP_FRAC_ZEROP_8(X) \
> > + ((X##_f[0] | X##_f[1] | X##_f[2] | X##_f[3] | \
> > + X##_f[4] | X##_f[5] | X##_f[6] | X##_f[7]) == 0)
>
> Again, break lines before not after operators, so | at start of line.
>
I will modify it. Thanks.