This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix C11 conformance issues

From: Joseph Myers <joseph at codesourcery dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: <libc-alpha at sourceware dot org>
Date: Wed, 25 Jul 2018 20:18:21 +0000
Subject: Re: [PATCH] Fix C11 conformance issues
References: <1532526205-5708-1-git-send-email-adhemerval.zanella@linaro.org> <alpine.DEB.2.20.1807251537160.19155@digraph.polyomino.org.uk> <0956cfd7-0f67-42fa-dee3-5aa12e5b554c@linaro.org>

On Wed, 25 Jul 2018, Adhemerval Zanella wrote:

> The patch below should fix it and the hurd specific stdc-predef.h with
> __STDC_NO_THREADS__ defined. I would like to avoid duplicating a file
> contents, but the other possible alternative which I can think of would
> add a platform specific file (empty for nptl case and defining 
> __STDC_NO_THREADS__ for htl) with the drawback of adding another
> include on every compilation (due extra include). I think we can
> live with a hurd specific stdc-predef.h for now.

This patch is OK.  The handling of precompiled headers in GCC is very 
fragile with regard to implicitly preincluded files and if stdc-predef.h 
were to include another header, there would be a significant chance of 
this breaking PCH.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH] Fix C11 conformance issues
  - From: Adhemerval Zanella
- Re: [PATCH] Fix C11 conformance issues
  - From: Joseph Myers
- Re: [PATCH] Fix C11 conformance issues
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]