This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, <libc-alpha at sourceware dot org>
- Date: Wed, 25 Jul 2018 10:29:32 +0000
- Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions
- References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <mvmh8knzsqd.fsf@suse.de>
On Wed, 25 Jul 2018, Andreas Schwab wrote:
> On Feb 02 2018, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>
> > @@ -197,7 +197,8 @@ linknamespace-libs-xsi = $(linknamespace-libs-posix) \
> > $(common-objpfx)crypt/libcrypt.a
> > linknamespace-libs-ISO = $(linknamespace-libs-isoc)
> > linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
> > -linknamespace-libs-ISO11 = $(linknamespace-libs-isoc)
> > +linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
> > + $(common-objpfx)nptl/libpthread.a
> > linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
> > $(common-objpfx)crypt/libcrypt.a
>
> You have reverted commit e69d994a63, which breaks --disable-crypt
> builds.
Also, the hardcoded reference to $(common-objpfx)nptl/libpthread.a should
be $(static-thread-library). As-is, the patch has broken the testsuite
build for Hurd (not just introduced the expected failures from lack of
support for C11 threads in HTL).
--
Joseph S. Myers
joseph@codesourcery.com