This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v2 5/5] Manual: Add manual for pthread mutex


OK. I will take a look at it.

-----Original Message-----
From: Rical Jasan [mailto:rj@2c3t.io] 
Sent: Wednesday, July 18, 2018 3:34 PM
To: Wang, Kemi <kemi.wang@intel.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>; Florian Weimer <fweimer@redhat.com>; Carlos Donell <carlos@redhat.com>; Glibc alpha <libc-alpha@sourceware.org>; Dave Hansen <dave.hansen@linux.intel.com>; Chen, Tim C <tim.c.chen@intel.com>; Kleen, Andi <andi.kleen@intel.com>; Huang, Ying <ying.huang@intel.com>; Lu, Aaron <aaron.lu@intel.com>; Li, Aubrey <aubrey.li@intel.com>
Subject: Re: [PATCH v2 5/5] Manual: Add manual for pthread mutex

On 07/12/2018 11:52 PM, Kemi Wang wrote:
> Pthread mutex is not described in the documentation, so I started to 
> document pthread mutex with PTHREAD_MUTEX_QUEUESPINNER type here at least.
> 
> Signed-off-by: Kemi Wang <kemi.wang@intel.com>
> ---
>  manual/Makefile   |  2 +-
>  manual/mutex.texi | 68 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 69 insertions(+), 1 deletion(-)  create mode 100644 
> manual/mutex.texi

I don't think this patch should create a new chapter.  There is already threads.texi---woefully incomplete as it may be (one and a half pages in the PDF and over 100 functions in the .texi file documented in comments as undocumented).  There are currently two sections in threads.texi:
Thread-specific Data and Non-POSIX Extensions.  I think this patch should introduce a new section in that chapter; something like Mutexes.

This issue is independent of the content, which I'll review separately.

Rical

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]