This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix string/tst-xbzero-opt if build with gcc head.

On 07/16/2018 02:36 PM, Zack Weinberg wrote:

On Mon, Jul 16, 2018 at 7:05 AM, Stefan Liebler <stli@linux.ibm.com> wrote:

On 07/12/2018 06:42 PM, Zack Weinberg wrote:

I would prefer us to find some kind of construct that
actually does make externally-visible side effects depend on the
contents of 'buf' in terms of the C abstract machine.



Okay. Then here is a new version of the patch without the empty asm.
If build with GCC head on s390x, setup_no_clear is now filling the buffer
and setup_ordinary_clear is just a tail call to setup_no_clear (same
behaviour as before).


Yes, this change is OK.

zw



Okay. Thank you.
Shall I commit this test-fix before or after the release?

Bye.
Stefan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]