This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] locale: XFAIL newlocale usage in static binary (Bug 23164)
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 5 Jul 2018 09:58:14 -0400
- Subject: Re: [PATCH] locale: XFAIL newlocale usage in static binary (Bug 23164)
- References: <3b445aba-1839-edab-537a-57db9987c220@redhat.com> <416728387.157880.1527119759246@poczta.nazwa.pl> <3a646905-2c23-c9b8-e1d6-801258bd4c2f@redhat.com> <94464150.411290.1530736087984@poczta.nazwa.pl>
On 07/04/2018 04:28 PM, Rafal Luzynski wrote:
> 4.07.2018 21:35 Carlos O'Donell <carlos@redhat.com> wrote:
>>
>> On 05/23/2018 07:55 PM, Rafal Luzynski wrote:
>>> This is a very incomplete review. So far I can only confirm that your
>>> patch compiles and adds one more XFAIL to the test results.
>>
>> Thanks for that review.
>>
>> I've committed what I posted.
>
> Thank you, good to see this commit pushed. Shouldn't you close the
> bug report as well, and mark the Target Milestone 2.28?
No, the bug is not fixed. I just added the regression tests that prove
the bug is not fixed. Someone still has to do the work to fix the bug.
So sadly the bug is still there :-( ... but having a reproducible test
case is half the battle.
>> [...]
>> In the future may I ask that you TO me directly on a review.
>> It's hard for me to filter reviews of my patches that only respond to
>> the list?
>
> That's what I usually do. Didn't I this time? I'm sorry about that.
> I don't understand why I did not, most probably my mistake. If I had
> any good reason then I don't remember it now, it's been a while ago.
Thanks. No worries. I found the review by going back to the list and
cross checking for any replies.
--
Cheers,
Carlos.