This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH1/2] Improve performance of sincosf


On Sat, 30 Jun 2018, Wilco Dijkstra wrote:

> Joseph Myers wrote:
> 
> > You then need to add a dummy s_sincosf_data.c for architectures with their 
> > own sincosf implementation, to avoid wasting space in libm.so with unused 
> > data from s_sincosf_data.c.  That looks like ia64, m68k, x86_64.
> 
> It's about 256 bytes so it's not a huge waste, I'll do it as a separate 
> enhancement when I get back from holiday.

I think the patch that adds a file only relevant to some targets should be 
the same patch that also avoids it building any code for other targets.

-- 
Joseph S. Myers
joseph@codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]