This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] posix: Sync gnulib regex implementation

From: Florian Weimer <fweimer at redhat dot com>
To: Paul Eggert <eggert at cs dot ucla dot edu>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
Date: Fri, 29 Jun 2018 17:41:54 +0200
Subject: Re: [PATCH] posix: Sync gnulib regex implementation
References: <1530204275-31537-1-git-send-email-adhemerval.zanella@linaro.org> <d5a88131-c50f-868d-b8b0-6115c5aa00ef@cs.ucla.edu> <135856c7-fee5-a5de-4ccb-12bf0b8fe166@linaro.org> <17feeb08-1478-21ae-e581-6ffecfddab5c@cs.ucla.edu>

On 06/29/2018 05:26 PM, Paul Eggert wrote:

As I recall the last time I suggested adding it, the only concern raisedwas over the licensing boilerplate at the start of the file. I havefixed that in Gnulib, so as far as I know the concerns have beenaddressed. We can make intprops.h's addition independent by separatingits addition into a separate patch, as I proposed in my most-recent email.

Most of intprops.h is untestable due to lack of relevant implementationsexisting out there on which the code could be tested, so I think it'snot maintainable and does not match current glibc quality standards.


Florian

Follow-Ups:
- Re: [PATCH] posix: Sync gnulib regex implementation
  - From: Adhemerval Zanella

References:
- [PATCH] posix: Sync gnulib regex implementation
  - From: Adhemerval Zanella
- Re: [PATCH] posix: Sync gnulib regex implementation
  - From: Paul Eggert
- Re: [PATCH] posix: Sync gnulib regex implementation
  - From: Adhemerval Zanella
- Re: [PATCH] posix: Sync gnulib regex implementation
  - From: Paul Eggert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]