This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/6] Use uint32_t sign in single precision math error handling, functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, <nd at arm dot com>
- Date: Thu, 28 Jun 2018 17:15:38 +0000
- Subject: Re: [PATCH 1/6] Use uint32_t sign in single precision math error handling, functions
- References: <bb5159bb-d5d7-9e24-9b97-8ea6f70fc907@arm.com>
On Wed, 27 Jun 2018, Szabolcs Nagy wrote:
> Ideally sign should be bool, but sometimes (e.g. in powf) it's more
> efficient to pass a non-zero value than 1 to indicate that the sign
> should be set. The fixed size int is less ambigous than unsigned
> long.
>
> 2018-06-27 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * sysdeps/ieee754/flt-32/e_powf.c (__powf): Use uint32_t.
> (exp2f_inline): Likewise.
> * sysdeps/ieee754/flt-32/math_config.h (__math_oflowf): Likewise.
> (__math_uflowf): Likewise.
> (__math_may_uflowf): Likewise.
> (__math_divzerof): Likewise.
> (__math_invalidf): Likewise.
> * sysdeps/ieee754/flt-32/math_errf.c (xflowf): Likewise.
> (__math_oflowf): Likewise.
> (__math_uflowf): Likewise.
> (__math_may_uflowf): Likewise.
> (__math_divzerof): Likewise.
> (__math_invalidf): Likewise.
OK.
--
Joseph S. Myers
joseph@codesourcery.com