This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4] Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251)



On 20/06/2018 18:49, Joseph Myers wrote:
> On Wed, 20 Jun 2018, Adhemerval Zanella wrote:
> 
>> +#include <shlib-compat.h>
>> +#if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_28)
>> +compat_symbol_reference (libc, fcntl, fcntl, GLIBC_2_0);
>> +#endif
> 
> I'd expect the entire test to be under such a TEST_COMPAT conditional 
> (returning 77 for UNSUPPORTED otherwise) - for a new port without older 
> symbol versions, no such compat version with compat semantics is available 
> for testing.
> 

Right, I forgot about news ports. I have adjusted it locally. Is this patch
ok to apply with this change?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]