Re: [PATCH 10/12] ldbl-128ibm-compat: Redirect long double functions to f128/ieee128 functions

[Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>]

Joseph Myers <joseph@codesourcery.com> writes:

> On Tue, 19 Jun 2018, Tulio Magno Quites Machado Filho wrote:
>
>>  #define __MATHREDIR(type, function, suffix, args, to) \
>>    extern type __REDIRECT_NTH (__MATH_PRECNAME (function, suffix), args, to)
>> @@ -364,6 +368,39 @@ extern long double __REDIRECT_NTH (nexttowardl,
>>  #   undef __MATHDECL_1
>>  #   define __MATHDECL_1(type, function,suffix, args) \
>>    __MATHREDIR(type, function, suffix, args, __CONCAT(function,suffix))
>> +
>
> And this is the __LDBL_COMPAT redefinition, I think.  You've moved various 
> functions to use __MATHDECL_ALIAS, but __MATHDECL_ALIAS isn't being 
> redefined for __LDBL_COMPAT.  Are you sure that's correct?  That is, what 
> do the macro-generated declarations of functions using __MATHDECL_ALIAS 
> look like in a -mlong-double-64 configuration, before and after this 
> patch?

You're right.  The default value for __MATHDECL_ALIAS should have been
__MATHDECL_1.
After changing it I get the following:

extern int __isinfl (long double __value) __asm__ ("" "__isinf") __attribute__ ((__nothrow__ , __leaf__))
  __attribute__ ((__const__));

>> +#define __dremieee128 __remainderieee128
>> +#define __gammaieee128 __lgammaieee128
>
> These are missing appropriate preprocessor indendation for their nesting 
> level inside #if.

Ack.  Fixed.

Thanks!

-- 
Tulio Magno