This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 07/13] nds32: Linux Syscall Interface

From: Vincent Chen <vincentc at andestech dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "deanbo422 at gmail dot com" <deanbo422 at gmail dot com>, "Che-Wei Chuang (??????)" <cnoize at andestech dot com>
Date: Fri, 15 Jun 2018 15:46:48 +0800
Subject: Re: [PATCH v3 07/13] nds32: Linux Syscall Interface
References: <1528960976-10934-1-git-send-email-vincentc@andestech.com> <1528960976-10934-8-git-send-email-vincentc@andestech.com> <alpine.DEB.2.20.1806141331580.20120@digraph.polyomino.org.uk>

On Thu, Jun 14, 2018 at 09:33:53PM +0800, Joseph Myers wrote:
> On Thu, 14 Jun 2018, Vincent Chen wrote:
> 
> > +/* This routine is jumped to by all the syscall handlers, to stash
> > +   an error number into errno.  */
> > +long int
> > +__syscall_error (long int err)
> > +{
> > +  __set_errno (- err);
> 
> We use spaces around binary operators, but not after unary '-'.
> 
> > +         __set_errno (INTERNAL_SYSCALL_ERRNO (result_var, err));     \
> > +			result_var = -1 ;			     \
> 
> No space before ';'.  The indentation of the second line here also seems 
> way off.  Likewise again later in this file.
>

I will modify these mistakes in the next version patch.

Thanks for your comment.



Vincent Chen
 
> -- 
> Joseph S. Myers
> joseph@codesourcery.com

References:
- [PATCH v3 00/13] nds32 glibc port, v3
  - From: Vincent Chen
- [PATCH v3 07/13] nds32: Linux Syscall Interface
  - From: Vincent Chen
- Re: [PATCH v3 07/13] nds32: Linux Syscall Interface
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]