This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PING: [PATCH] benchtests: Add -f/--functions argument
- From: Victor Rodriguez <vm dot rod25 at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 12 Jun 2018 09:45:55 -0500
- Subject: Re: PING: [PATCH] benchtests: Add -f/--functions argument
- References: <CAMe9rOqid5ksKa=tt5fu43Oox5khKF=+ESPcb5XF+s_wxBEkhg@mail.gmail.com>
On Tue, Jun 12, 2018 at 9:29 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, May 24, 2018 at 10:40 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> On x86-64, there may be multiple IFUNC implementations for a given
>> function. But we may be only interested in a subset of them. This
>> patch adds -f/--functions argument to compare a subset of IFUNC
>> implementations.
>>
>> Any comments?
>>
>>
>> H.J.
>> ---
>> * benchtests/scripts/compare_strings.py (process_results): Add
>> funcs argument. Compare only functions which are selected.
>> (main): Check if base function is among selected functions.
>> Pass selected functions to process_results.
>> (__main__): Add -f/--functions argument.
>
> I rebased my patch against the current master.
>
> Any comments, objections?
>
+1 i like the idea funcs argument.
> --
> H.J.