This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 05/12] nds32: Generic <math.h> and soft-fp Routines


On Wed, 30 May 2018, Vincent Chen wrote:

> +    FE_TONEAREST =
> +#define FE_TONEAREST	1
> +      FE_TONEAREST,
> +  };

As noted in RISC-V port review, C90 / C++98 don't support trailing commas 
in enum definitions, so you shouldn't have a comma after the last element 
of an enum defined in an installed header.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]