This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: commit reversion without review
On 05/10/2018 01:21 AM, Alexandre Oliva wrote:
> Indeed, I posted just an offer of reversal (the patch for a revert is
> the same as the initial patch, applied with -R). Others had signaled
> the reversal as a possibility before ("I won't revert it myself, but if
> you can find someone else to do it", quoted form memory). I waited for
> days after the offer, and no one responded to it other than Richard. So
> I understood there was consensus to restore the initial conditions and
> installed it.
You did not have consensus.
>> So let me reiterate: next time please post your proposed commits for review.
>
> I did, but AFAICT nobody read it, so nobody objected, so it went in.
> What I did NOT do was to post the patch, which I still think is not
> necessary for a revert, and I did NOT post it as a separate thread,
> which I now regret, for it would have made it more visible, so there
> wouldn't be much doubt about whether objections applied to it (they'd be
> raised in response to the proposal, I suppose)
>
> In case you missed the proposed commit, see
> https://sourceware.org/ml/libc-alpha/2018-05/msg00053.html
> and look at the very end:
>
> [...] I offer to reverse the patch myself, if the person who pushed
> it in doesn't do so in the next few days, so that we can then seek
> consensus without the fait accompli artificially shifting the
> baseline.
>
> this was in response (as in reaction, not followup) to:
> https://sourceware.org/ml/libc-alpha/2018-05/msg00010.html
>
> if you want that change reverted, you will have to find someone else
> willing to do that; I won't.
Dmitry is right. Please listen to what he has to say.
--
Cheers,
Carlos.