Re: Add PTRACE_SECCOMP_GET_METADATA from Linux 4.16 to sys/ptrace.h

["Dmitry V. Levin" <ldv at altlinux dot org>]

On Mon, Apr 23, 2018 at 11:23:05PM +0000, Joseph Myers wrote:
> On Mon, 23 Apr 2018, Dmitry V. Levin wrote:
> > On Mon, Apr 23, 2018 at 05:07:25PM +0000, Joseph Myers wrote:
> > > On Mon, 23 Apr 2018, Dmitry V. Levin wrote:
> > > > On Mon, Apr 23, 2018 at 03:56:48PM +0000, Joseph Myers wrote:
> > > > > This patch adds the PTRACE_SECCOMP_GET_METADATA constant from Linux
> > > > > 4.16 to all relevant sys/ptrace.h files.
> > > > 
> > > > Thanks, I haven't managed to submit this update myself.
> > > > 
> > > > This has to be committed along with the following two changes:
> > > > - adding #undef PTRACE_SECCOMP_GET_METADATA to all files that already
> > > >   undefine PTRACE_SECCOMP_GET_FILTER, for exactly the same reason;
> > > 
> > > I believe this patch does that.
> > 
> > It is not mentioned in the ChangeLog entry, so I must have missed it
> > in the patch itself.
> 
> I think mentioning the name as a new macro and enum value is sufficient 
> without going into the details of how in certain headers a new macro also 
> involves a #undef.
> 
> > > > - adding to bits/ptrace-shared.h a definition equivalent
> > > >   to struct seccomp_metadata.
> > > 
> > > This may be useful, but I don't see it as necessary to add the constant.
> > 
> > The constant is useless without the corresponding structure.
> 
> Which a user could provide themselves if they wish.

Given the problematic definition of the structure before the linux commit
v4.16-rc3~9^2~2^2~2, it's better to provide a proper definition.

> Anyway, this patch 
> version adds such a structure, named struct __ptrace_seccomp_metadata by 
> analogy to other such structures there.
> 
> 
> Add PTRACE_SECCOMP_GET_METADATA from Linux 4.16 to sys/ptrace.h.
> 
> This patch adds the PTRACE_SECCOMP_GET_METADATA constant from Linux
> 4.16 to all relevant sys/ptrace.h files.  A type struct
> __ptrace_seccomp_metadata, analogous to other such types, is also
> added.

Looks good, thanks.


-- 
ldv

Attachment: signature.asc
Description: PGP signature