This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Overhaul __libc_check_standard_fds and correct open modes.

From: Florian Weimer <fweimer at redhat dot com>
To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
Cc: schwab at suse dot de
Date: Mon, 16 Apr 2018 09:16:46 +0200
Subject: Re: [PATCH] Overhaul __libc_check_standard_fds and correct open modes.
References: <20180414223109.4170-1-zackw@panix.com>

On 04/15/2018 12:31 AM, Zack Weinberg wrote:

This strikes me as unwise.  The whole point of
this function is to backstop insufficiently defensively programmed
suid executables.  If they're not themselves taking precautions
against fds 0, 1, and 2 being closed, why do we believe they are
checking for the unusual errors that will occur as a result of fd 0
being open O_WRONLY, and so on?

These defensive descriptors could be inherited by child processes, whichperform such checking.


Thanks,
Florian

References:
- [PATCH] Overhaul __libc_check_standard_fds and correct open modes.
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]