This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] manual: Result of mbrtowc is a single wide character


On 04/04/2018 04:21 PM, Andreas Schwab wrote:
On Apr 04 2018, fweimer@redhat.com (Florian Weimer) wrote:

diff --git a/manual/examples/mbstouwcs.c b/manual/examples/mbstouwcs.c
index 5d223da2ae..3a8b9a65f9 100644
--- a/manual/examples/mbstouwcs.c
+++ b/manual/examples/mbstouwcs.c
@@ -20,7 +20,7 @@ mbstouwcs (const char *s)
        if (nbytes >= (size_t) -2)
          /* Invalid input string.  */
          return NULL;
-      *wcp++ = towupper (tmp[0]);
+      *wcp++ = towupper (*tmp);

tmp is declared as an array, so tmp[0] is more natural.

Thanks.  I'm going to fold this change into the other patch.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]