This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] Tunables: Add tunables of spin count for adaptive spin mutex
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, kemi <kemi dot wang at intel dot com>
- Cc: Dave Hansen <dave dot hansen at linux dot intel dot com>, Tim Chen <tim dot c dot chen at intel dot com>, Andi Kleen <andi dot kleen at intel dot com>, Ying Huang <ying dot huang at intel dot com>, Aaron Lu <aaron dot lu at intel dot com>, Glibc alpha <libc-alpha at sourceware dot org>, aubrey <aubrey dot li at intel dot com>
- Date: Wed, 4 Apr 2018 20:11:07 -0500
- Subject: Re: [PATCH 1/3] Tunables: Add tunables of spin count for adaptive spin mutex
- References: <1522394093-9835-1-git-send-email-kemi.wang@intel.com> <03d60e93-a167-1401-b67e-22d7d2443486@intel.com> <f65e64f5-7289-faa4-2314-71ce5e904bf0@linaro.org>
On 04/04/2018 12:16 PM, Adhemerval Zanella wrote:
>>> Also I not sure if it worth to add environment variable for this tunable,
>>> I would rather avoid adding newer ones (and naming seems off, since afaik
>>> LD_* meaning some parameters that affects the loader).
>>>
>>
>> AFAIK, environment variable is what I can think of to give people the possibility of
>> tunes in shell for that, maybe you have better idea?
>>
>> Yes, we probably use other name like MUTEX_SPIN_COUNT to avoid confusion, agree?
>
> The tunables framework already provides a environment variable to this [1],
> the 'env_alias' is mainly to provide compatibility and to use the same logic
> internally.
>
> So I think it is better to use the default tunable env var.
>
> [1] https://www.gnu.org/software/libc/manual/html_node/Tunables.html
Fully agree. We should never add any new environment variable, they should all be
automatically used from the top-level tunable env var.
--
Cheers,
Carlos.