This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] malloc: harden removal from unsorted list


On 03/14/2018 09:47 PM, DJ Delorie wrote:
Florian Weimer <fweimer@redhat.com> writes:
Gentle ping - anything required on my end here (e.g. pull request)?

I'm OK with it.  Florian?  Any further comments?

The latest commit looks okay.  Can you commit it in François's name?

Done.

Probably should have a bz associated with it too, though.  And a test
case, eventually.

It's not user-visibile, so it doesn't need a bug.

Hardening test cases are intrinsically difficult to write and probably of little value. You need to make sure that change not merely breaks one specific case, but entire exploitation strategy. Otherwise, why bother with adding this kind of hardening?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]