This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 1/3] Cleanup __ieee754_sqrt(f/l)
On Thu, 15 Mar 2018, Wilco Dijkstra wrote:
> 2018-03-15 Wilco Dijkstra <wdijkstr@arm.com>
>
> * include/math.h (sqrt): Declare with asm redirect.
> (sqrtf): Likewise.
> (sqrtl): Likewise.
> (sqrtf128): Likewise.
> * Makeconfig: Add -fno-math-errno for libc/libm, but build testsuite,
> nonlib and libnldbl with -fmath-errno.
> * math/w_sqrt_compat.c: Define NO_MATH_REDIRECT.
> * math/w_sqrt_template.c: Likewise.
> * math/w_sqrtf_compat.c: Likewise.
> * math/w_sqrtl_compat.c: Likewise.
> * sysdeps/generic/math-type-macros-float128.h: Remove math.h and complex.h.
> * sysdeps/i386/fpu/w_sqrt.c: Likewise.
> * sysdeps/i386/fpu/w_sqrt_compat.c: Likewise.
The sysdeps/generic/math-type-macros-float128.h entry should come at the
end, otherwise the "Likewise" for the subsequent two files is incorrect,
since it's not math.h and complex.h includes being removed from them, it's
NO_MATH_REDIRECT defines being added.
> +# if !(defined __FINITE_MATH_ONLY__ && __FINITE_MATH_ONLY__ > 0)
> +# ifndef NO_MATH_REDIRECT
> +/* Declare sqrt for use within GLIBC. Sqrt will typically inline into a
sqrt not Sqrt at the start of a sentence (see the GNU Coding Standards:
"If a lower-case identifier comes at the beginning of a sentence, don't
capitalize it! Changing the spelling makes it a different identifier.
If you don't like starting a sentence with a lower case letter, write the
sentence differently (e.g., ``The identifier lower-case is @dots{}'').").
This patch is OK with those changes.
--
Joseph S. Myers
joseph@codesourcery.com