This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86: Add __sigsetjmp_cancel and __setjmp_cancel
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>, Florian Weimer <fw at deneb dot enyo dot de>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 15 Mar 2018 16:36:22 +0000
- Subject: Re: [PATCH] x86: Add __sigsetjmp_cancel and __setjmp_cancel
- References: <CAMe9rOoB0t6CffwX-wgbBGNtaGgD923WoWmrtCjiXLc5pm=Z9g@mail.gmail.com>
On Thu, 15 Mar 2018, H.J. Lu wrote:
> +extern int __sigsetjmp_cancel (struct __jmp_buf_tag *__env, int __savemask)
> + __THROWNL __attribute__((__returns_twice__));
I think you should define __attribute_returns_twice__ in misc/sys/cdefs.h
(defined to empty if !__GNUC_PREREQ (4, 1)), then use it here.
Missing space before '(' after __attribute__.
--
Joseph S. Myers
joseph@codesourcery.com