This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use correct includes in benchtests
On Thursday 15 March 2018 08:12 PM, Zack Weinberg wrote:
> On Thu, Mar 15, 2018 at 10:29 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>> Currently the benchtests are run with internal GLIBC headers, which is incorrect.
>> Defining _ISOMAC in the makefile ensures the internal headers are bypassed.
>> Fix all tests which were relying on internal defines or includes.
> ...
>> -CPPFLAGS-nonlib += -DDURATION=$(BENCH_DURATION)
>> +CPPFLAGS-nonlib += -DDURATION=$(BENCH_DURATION) -D_ISOMAC
>
> Is there a reason you can't change `lib := nonlib` to `lib :=
> testsuite` in the invocation of libof-iterator.mk, instead? Several
> other places in the Makefile would need to be changed, but using the
> testsuite module is abstractly more appropriate and might have other
> desirable effects in the future (e.g. not including libc-symbols.h at
> all).
It's been a while since I touched those bits but IIRC nonlib is treated
specially, which is why I had made it nonlib. If it's not, then calling
it benchtests is a good idea (and then have testsuite for all the test
programs, although I believe some test programs test internals; they
need to be split out too eventually), but orthogonal to this change.
Siddhesh