This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use correct includes in benchtests

From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
Cc: nd <nd at arm dot com>
Date: Thu, 15 Mar 2018 20:04:36 +0530
Subject: Re: [PATCH] Use correct includes in benchtests
References: <DB6PR0801MB20534A15313278C542ACB40983D00@DB6PR0801MB2053.eurprd08.prod.outlook.com>

On Thursday 15 March 2018 07:59 PM, Wilco Dijkstra wrote:
> Currently the benchtests are run with internal GLIBC headers, which is incorrect.
> Defining _ISOMAC in the makefile ensures the internal headers are bypassed.
> Fix all tests which were relying on internal defines or includes.
> 
> Benchtests now run with correct headers on AArch64.
> 
> OK for commit?
> 
> ChangeLog:
> 2018-03-15  Wilco Dijkstra  <wdijkstr@arm.com>
> 
> 	* benchtests/Makefile: Define _ISOMAC.
> 	* benchtests/bench-strcoll.c: Add missing sys/stat.h include.
> 	* benchtests/bench-string.h: Define inhibit_loop_to_libcall macro.
> 	* benchtests/bench-strstr.c: Define empty libc_hidden_builtin_def.
> 	* benchtests/bench-strtok.c (oldstrtok): Use rawmemchr.
> 

OK.

Siddhesh

References:
- [PATCH] Use correct includes in benchtests
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]