This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] aarch64: Improve strncmp for mutually misaligned inputs
On Wednesday 14 March 2018 06:05 PM, Szabolcs Nagy wrote:
> this broke the build for me
>
> ../sysdeps/aarch64/strncmp.S: Assembler messages:
> ../sysdeps/aarch64/strncmp.S:211: Error: unexpected characters following
> instruction at operand 2 -- `mov x13,x2,lsr#3'
> ../sysdeps/aarch64/strncmp.S:217: Error: unexpected characters following
> instruction at operand 2 -- `mov x13,x2,lsr#3'
>
> old binutils 2.26 and before did not support mov with shifted
> register (only orr reg,xzr,reg,shift).
>
> but i think a shift instruction (lsr) should be better anyway
> (on most implementations).
>
> can you please fix this?
Thanks for pointing out, I've pushed this patch[1] after testing it on a
xenial box, which showed this error. This was my old builder and I
recently moved to a new one based on bionic because of which I didn't
see this problem earlier.
Siddhesh
[1]
https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=d46f84de745db8f3f06a37048261f4e5ceacf0a3