This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/9] Add __vsyslog_internal, with same flags as __v*printf_internal.
On Tue, Mar 13, 2018 at 9:50 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>> Some architectures will still use indirect calls without
>>> attribute_hidden,
>>> so please add it. The existing tests do not catch this reliably
>>> unfortunately.
>>
>>
>> Can you be more specific? This will affect all of the other new
>> __*_internal functions added in this patchset, so I need to know how
>> to be sure I got it right. Also, this seems like something we should
>> find a way to automate if at all possible.
...
> The linker may have some optimization to eliminate the PLT indirection
> (blinding the localplt test), but it cannot get rid of the other unnecessary
> instructions.
>
> Does this example help?
I believe I understand the problem now, thank you. And we can't/don't
use -fvisibility=hidden because then we would have to annotate all of
the _public_ symbols with visibility default, yes?
zw