This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [hurd,commited] hurd: do not check Mach and Hurd headers
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Samuel Thibault <samuel dot thibault at ens-lyon dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Sat, 3 Mar 2018 22:08:49 +0000
- Subject: Re: [hurd,commited] hurd: do not check Mach and Hurd headers
- Authentication-results: sourceware.org; auth=none
- References: <20180303191852.19319-1-samuel.thibault@ens-lyon.org>
On Sat, 3 Mar 2018, Samuel Thibault wrote:
> as they are not standard.
That's not a sufficient reason for this change. What this script is
checking is nothing to do with whether the headers are standard; it's that
each header can be included in isolation with any supported feature test
macro defined (actually, just a few macros are tested) and in any C/C++
standards mode.
That property should apply to Hurd-specific headers installed by glibc
just as it applies to non-Hurd-specific headers (this script doesn't test
headers not installed by glibc). That is, any case of such a header
failing this test is presumptively a bug that should be fixed. (If a
header is in fact purely internal, not for direct use by users or by other
installed headers, stopping it being installed is the correct fix - this
test is specifically for installed headers. If a header is installed only
for use by other installed headers and is not meant to be included
directly by user programs, it should move into bits/; bits/ headers are
already excluded from this test.)
--
Joseph S. Myers
joseph@codesourcery.com